Re: [PATCH net v12 1/4] net: usb: lan78xx: register the PHY interrupt with the MDIO bus

[Andrew Lunn]

On Wed, Sep 30, 2026 at 12:58:20AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] In lan78xx_mdio_init() (drivers/net/usb/lan78xx.c:2122-2124),
>   the one mapped PHY interrupt (domain_data.phyirq, backed only by…
> 
> --
> 
> net: usb: lan78xx: register the PHY interrupt with the MDIO bus
> 
> This patch moves the lan78xx PHY interrupt out of lan78xx_phy_init(),
> where it was written directly to phydev->irq. It now goes into the
> mii_bus irq[] table before of_mdiobus_register() is called. Every entry
> in the table is set to domain_data.phyirq, so the PHY created by the
> scan picks it up through phy_device_create().
> 
> > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> > index 5655941f14783..522fb4daeb468 100644
> > --- a/drivers/net/usb/lan78xx.c
> > +++ b/drivers/net/usb/lan78xx.c
> 
> [ ... ]
> 
> > @@ -2118,6 +2119,10 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev)
> >  		break;
> >  	}
> >  
> > +	if (dev->domain_data.phyirq > 0)
> > +		for (i = 0; i < PHY_MAX_ADDR; i++)
> > +			dev->mdiobus->irq[i] = dev->domain_data.phyirq;
> > +
> 
> [Severity: Medium]
> On LAN7801, could this mark PHYs that are not wired to the LAN7801 PHY_INT
> input as interrupt driven?

Since this is a USB dongle, it is unlikely. However, i agree with the
general principal. The code should only change the one entry the PHY
is actually using. Please look at all the patches in this series.

   Andrew