Re: [PATCH net] net: ti: icssg-prueth: Fix switch mode for offload and non-offload cases

[Andrew Lunn]

On Wed, Sep 30, 2026 at 06:13:56PM +0530, Meghana Malladi wrote:
> Non-offloaded switch mode is failing to forward packets. Following fixes
> ensure smooth operation of switch mode in both offload and non-offload cases:
> 
> - Fix NULL dereference in icssg_enable_fw_offload() when second emac
>   slot is uninitialized during first port open
> - Set port_vlan on both emacs when bridge is formed; previously only
>   the second port was set, causing TX stalls in switch offload mode
> - Track UC/MC flooding state and restore it after firmware restart in
>   non-offload bridge mode; restart cleared IFF_PROMISC-driven flooding,
>   breaking unicast forwarding across bridge ports
> - Defer emac_adjust_link() to after prueth_emac_start() so R30 FORWARD
>   commands don't time out with PRU not running, leaving stale R30 values
>   that caused prueth_emac_restart() to fail in non-offload bridge mode

A bullet point list in the commit message suggests there should be a
patch series of patches, not one patch. You want small, obviously
correct patches with good commit messages.


    Andrew

---
pw-bot: cr