Re: [PATCH 2/2] arm64: dts: mediatek: mt7988a-bpi-r4pro: label gpio-hogs

[Linus Walleij]

On Fri, Sep 18, 2026 at 4:39 PM Frank Wunderlich <linux@xxxxxxxxx> wrote:

> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>
> GPIO hogs were tagged with name "?" in recent kernel versions (7.1+) due to
> commit d1d564ec4992 ("gpio: move hogs into GPIO core").
>
> 7.0 showed the unit-name which behaviour is restored by patch [1], but
> labeling the hog directly makes things easier.
>
> gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
>  gpio-0   (                    |tx-disable          ) in  lo
>  gpio-1   (                    |mod-def0            ) in  hi IRQ ACTIVE LOW
>  gpio-2   (                    |los                 ) in  hi IRQ
>  gpio-12  (                    |cd                  ) in  lo IRQ ACTIVE LOW
>  gpio-13  (                    |reset               ) in  hi IRQ ACTIVE LOW
>  gpio-14  (                    |WPS                 ) in  hi IRQ ACTIVE LOW
>  gpio-21  (                    |tx-disable          ) in  lo
>  gpio-63  (                    |?                   ) out hi
>  gpio-69  (                    |mod-def0            ) in  hi IRQ ACTIVE LOW
>  gpio-70  (                    |los                 ) in  hi IRQ
>  gpio-79  (                    |?                   ) out lo
>  gpio-82  (                    |PHY reset           ) out hi ACTIVE LOW
>  gpio-83  (                    |PHY reset           ) out hi ACTIVE LOW
>
> after the change:
>
> root@bpi-r4:~# cat /sys/kernel/debug/gpio
> gpiochip0: 84 GPIOs, parent: platform/1001f000.pinctrl, pinctrl_moore:
>  gpio-0   (                    |tx-disable          ) in  lo
>  gpio-1   (                    |mod-def0            ) in  hi IRQ ACTIVE LOW
>  gpio-2   (                    |los                 ) in  hi IRQ
>  gpio-12  (                    |cd                  ) in  lo IRQ ACTIVE LOW
>  gpio-13  (                    |reset               ) in  hi IRQ ACTIVE LOW
>  gpio-14  (                    |WPS                 ) in  hi IRQ ACTIVE LOW
>  gpio-21  (                    |tx-disable          ) in  lo
>  gpio-63  (                    |pcie3-cn14-hog      ) out hi
>  gpio-69  (                    |mod-def0            ) in  hi IRQ ACTIVE LOW
>  gpio-70  (                    |los                 ) in  hi IRQ
>  gpio-79  (                    |pcie2-cn15-hog      ) out lo
>  gpio-82  (                    |PHY reset           ) out hi ACTIVE LOW
>  gpio-83  (                    |PHY reset           ) out hi ACTIVE LOW
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git/commit/?id=d54a489c8c4b627775445d54a6cbd32f209bda8f
> "gpiolib: use of_node_name if line-name is missing"
>
> Fixes: d1d564ec4992 ("gpio: move hogs into GPIO core")
> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>

It's always good to use line-names on boards for tinkering
makerspaces prototyping etc.

Reviewed-by: Linus Walleij <linusw@xxxxxxxxxx>

Yours,
Linus Walleij