Re: [PATCH net-next v2] selftests: fib_tests: use per-test return value in subtests

From: Ido Schimmel

Date: Wed Sep 30 2026 - 10:34:04 EST


On Wed, Sep 30, 2026 at 10:06:24AM +0800, Hangbin Liu wrote:
> From: Hangbin Liu <liuhangbin@xxxxxxxxxx>
>
> fib_tests mixes use of $ret for both per-test return value and global exit
> code. If an earlier subtest fails and a later function sets ret=0, the
> script will exit with status 0 even though [FAIL] lines were printed.
>
> Use RET as the per-test return value, as already defined in lib.sh. The
> exit code ret will only be set in log_test().
>
> Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>

Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>