Re: linux-next: manual merge of the kvm-x86 tree with the kvm-fixes tree
From: Mark Brown
Date: Wed Sep 30 2026 - 10:43:33 EST
On Wed, Sep 30, 2026 at 06:40:07AM -0700, Sean Christopherson wrote:
> On Wed, Sep 30, 2026, Mark Brown wrote:
> > between commits:
> > b630929bcc4c8 ("KVM: selftests: Extend nested x2APIC test to validate disabling x2APIC virt")
> > b0bc51910f039 ("KVM: selftests: Extend nested x2APIC test to validate using eVMCS for vmcs12")
> > from the kvm-fixes tree and commits:
> > 9b2f8146fcef9 ("KVM: selftests: Extend nested x2APIC test to validate disabling x2APIC virt")
> > a4bab1c12fd52 ("KVM: selftests: Extend nested x2APIC test to validate using eVMCS for vmcs12")
> kvm-fixes got force-pushed, which is what's causing the weird conflict. In a
> tree that hasn't refresh from kvm.git, I see:
Ah, I had thought it was an old version of the patch having landed in
kvm-x86. It looked like different versions of the same patch got into
each tree so I went with the main fixes branch version as that's what's
heading for Linus. This sort of cherry pick/duplicate stuff is always
hard to follow. :(
> a4bab1c12fd528ccaafee00360e07463873404a9 (kvm/master, kvm/HEAD) KVM: selftests: Extend nested x2APIC test to validate using eVMCS for vmcs12
> 9b2f8146fcef9faa73f9dc1bad9a8d6c585cfec8 KVM: selftests: Extend nested x2APIC test to validate disabling x2APIC virt
> versus the newer version:
> 973ea70393e885e540f714904e51bc6cac80e3d7 (kvm/master, kvm/HEAD) KVM: SEV: Do cache maintenance on the source VM *before* clearing SEV state
> 8abbc76120a74bfba1851bd97528099d715e45c6 KVM: SEV: Nullify "have run CPUs" mask pointer when freeing it
> b0bc51910f0391fea09c0a1d32352fec2acb2686 KVM: selftests: Extend nested x2APIC test to validate using eVMCS for vmcs12
> b630929bcc4c867c9abc8cd5a0ebee3bb5ce5dcd KVM: selftests: Extend nested x2APIC test to validate disabling x2APIC virt
IIRC my conflict resolution gitk only showed me the two commits that got
duplicated, it is filtered by file though.
> > - prepare_for_vmx_operation(vmx);
> > + GUEST_ASSERT_EQ(prepare_for_vmx_operation(vmx), true);
> This resolution will probably break the final selftests build? kvm-x86/next
> moves these asserts into prepare_for_vmx_operation(), load_evmcs(), load_vmcs()
> etc. I.e. kvm-x86/next should "win".
That's entirely plausible, my kselftest build tests are for arm64 only
since that's what's native on the build machine. Sorry about the mess
here. If you send me a confirmed resolution on top of today's -next I
can add the fixup, or I'll try to take look tomorrow?
Attachment:
signature.asc
Description: PGP signature