Re: [PATCH v2 2/2] selftests/sched_ext: Add a test for ops.dequeue() on remote local DSQ moves

From: Kuba Piecuch

Date: Wed Sep 30 2026 - 11:00:00 EST


Hi Andrea,

On Wed, Sep 30, 2026 at 03:53:47PM +0200, Andrea Righi wrote:
> If there are MAX_DISPATCH_POPS or more stale entries in front of a valid one, we
> return without dispatching anything and the CPU goes idle. It's quite unlikely,
> but maybe we could re-kick this CPU when the loop runs out of pops while the
> queue is still non-empty to make the test a bit more robust?

Good idea. v3 uses bpf_map_peek_elem() to check the queue and kicks the CPU
if the queue is not empty.

> Nit: maybe reset enqueue_seq as well?

Done.

> Nit: uei isn't reset between scenarios, so in theory this check in the
> second scenario could pass using the exit record of the first one. So maybe we
> should add:
>
> memset(&skel->data->uei, 0, sizeof(skel->data->uei));

Good catch, done.

> Reviewed-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks for the review! I've added your tag in v3.

Thanks,
Kuba