Re: [PATCH] drm/virtio: add ARGB8888 support for primary planes

[Thomas Zimmermann]

Hi

Am 30.09.26 um 15:27 schrieb Dorinda Bassey:
> Add DRM_FORMAT_HOST_ARGB8888 to the list of supported formats for
> virtio-gpu primary planes. Without this, glmark2-drm fails at
> startup because it selects ARGB visual configs by default, which
> don't match the XRGB-only plane capabilities. This causes
> drmModeSetCrtc to fail with EINVAL.

But does the host also support ARGB on the primary plane? We usually 
don't export formats that are not available in (virtual) hardware.

Best regards
Thomas

> The virtio_gpu_translate_format() function already handles
> ARGB8888 translation to VIRTIO_GPU_FORMAT_B8G8R8A8_UNORM,
> so this just exposes the existing capability to userspace.
>
> Signed-off-by: Dorinda Bassey <dbassey@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/virtio/virtgpu_plane.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
> index b422eba42a5f..5f0bc1b1931b 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
> @@ -37,6 +37,7 @@
>   
>   static const uint32_t virtio_gpu_formats[] = {
>   	DRM_FORMAT_HOST_XRGB8888,
> +	DRM_FORMAT_HOST_ARGB8888,
>   };
>   
>   static const uint32_t virtio_gpu_cursor_formats[] = {

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)