Re: [PATCH v2 05/21] media: i2c: it6625: drop stale GCC < 4.4.6 workaround
From: Hans Verkuil
Date: Wed Sep 30 2026 - 11:38:05 EST
On 30/09/2026 08:41, Hermes Wu via B4 Relay wrote:
> From: Hermes Wu <Hermes.wu@xxxxxxxxxx>
>
> The kernel-wide minimum GCC version is 8.1 (scripts/min-tool-version.sh),
> so the explicit .reserved = { 0 } initializer kept for GCC < 4.4.6 is no
> longer needed in either v4l2_dv_timings_cap initializer.
FYI: I'm dropping this patch. It might be OK against the oldest gcc version,
but for the oldest llvm version this is still needed.
Regards,
Hans
>
> Signed-off-by: Hermes Wu <Hermes.wu@xxxxxxxxxx>
> ---
> drivers/media/i2c/it6625.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
> index b09b331b20364a8e169429bb309d1112ec83d919..b747c08e092c7b35994cb36bb5bf7b99495282cb 100644
> --- a/drivers/media/i2c/it6625.c
> +++ b/drivers/media/i2c/it6625.c
> @@ -331,8 +331,6 @@ static const s64 it6625_link_freq[] = {
> */
> static const struct v4l2_dv_timings_cap it6625_timings_cap = {
> .type = V4L2_DV_BT_656_1120,
> - /* keep this initialization for compatibility with GCC < 4.4.6 */
> - .reserved = { 0 },
>
> V4L2_INIT_BT_TIMINGS(640, 3840, 480, 2160, 27000000, 300000000,
> V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT |
> @@ -347,7 +345,6 @@ static const struct v4l2_dv_timings_cap it6625_timings_cap = {
> */
> static const struct v4l2_dv_timings_cap it6626_cphy_3trio_timings_cap = {
> .type = V4L2_DV_BT_656_1120,
> - .reserved = { 0 },
>
> V4L2_INIT_BT_TIMINGS(640, 3840, 480, 2160, 27000000, 594000000,
> V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT |
>