Re: [PATCH] can: peak_usb: Add support of loopback mode to the PCAN-USB FD family

[Marc Kleine-Budde]

On 30.09.2026 16:24:44, Stéphane Grosjean wrote:
> > > @@ -1266,7 +1272,7 @@ const struct peak_usb_adapter pcan_usb_fd = {
> > >  	.ctrlmode_supported = CAN_CTRLMODE_FD |
> > >  			CAN_CTRLMODE_3_SAMPLES | CAN_CTRLMODE_LISTENONLY |
> > >  			CAN_CTRLMODE_ONE_SHOT | CAN_CTRLMODE_CC_LEN8_DLC |
> > > -			CAN_CTRLMODE_BERR_REPORTING,
> > > +			CAN_CTRLMODE_BERR_REPORTING | CAN_CTRLMODE_LOOPBACK,
> >
> > Can you keep the CAN_CTRLMODE sorted by their value?
> >
> > Please make an incremental patch for the CAN_CTRLMODE_BERR_REPORTING,
> > I'll squash that...and add CAN_CTRLMODE_LOOPBACK in the appropriate
> > place.
>
> Do you want me to post a v2 of this patch with the CAN_CTRLMODE flags
> sorted by value, or do you prefer a separate incremental patch on top
> of the bus error reporting series?

Sorry for being unclear. :)

Please a separate incremental patch on top of the bus error reporting
series.

Then post a v2 of the loopback patch on top of the incremental patch.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature