[PATCH v2 05/22] firmware: ti_sci: Name response variable resp for consistency
From: Beleswar Padhi
Date: Wed Sep 30 2026 - 12:41:40 EST
From: Andrew Davis <afd@xxxxxx>
All other TI-SCI call functions call the response variable "resp" except
ti_sci_cmd_get_revision(), fix this here. Also get assign the response
variable pointer after the transfer, again for consistency. No functional
change but does make later cleanups easier.
Signed-off-by: Andrew Davis <afd@xxxxxx>
Signed-off-by: Beleswar Padhi <b-padhi@xxxxxx>
---
v2: Changelog:
1. None to this patch.
Link to v1:
https://lore.kernel.org/all/20260929201746.4078803-6-b-padhi@xxxxxx/
drivers/firmware/ti_sci.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
index a91db923c8939..9081288bd133c 100644
--- a/drivers/firmware/ti_sci.c
+++ b/drivers/firmware/ti_sci.c
@@ -507,27 +507,27 @@ static int ti_sci_cmd_get_revision(struct ti_sci_info *info)
{
struct ti_sci_handle *handle = &info->handle;
struct ti_sci_version_info *ver = &handle->version;
- struct ti_sci_msg_resp_version *rev_info;
+ struct ti_sci_msg_resp_version *resp;
struct ti_sci_xfer *xfer;
int ret;
xfer = ti_sci_get_one_xfer(info, TI_SCI_MSG_VERSION,
TI_SCI_FLAG_REQ_ACK_ON_PROCESSED,
sizeof(struct ti_sci_msg_hdr),
- sizeof(*rev_info));
+ sizeof(*resp));
if (IS_ERR(xfer))
return PTR_ERR(xfer);
- rev_info = (struct ti_sci_msg_resp_version *)xfer->xfer_buf;
-
ret = ti_sci_do_xfer(info, xfer);
if (ret)
goto fail;
- ver->abi_major = rev_info->abi_major;
- ver->abi_minor = rev_info->abi_minor;
- ver->firmware_revision = rev_info->firmware_revision;
- strscpy(ver->firmware_description, rev_info->firmware_description,
+ resp = (struct ti_sci_msg_resp_version *)xfer->xfer_buf;
+
+ ver->abi_major = resp->abi_major;
+ ver->abi_minor = resp->abi_minor;
+ ver->firmware_revision = resp->firmware_revision;
+ strscpy(ver->firmware_description, resp->firmware_description,
sizeof(ver->firmware_description));
fail:
--
2.34.1