Re: [PATCH net-next v4 2/5] fbnic: Track BDQ device-page geometry per ring

[Joe Damato]

On Fri, Sep 25, 2026 at 12:44:09PM +0200, Björn Töpel wrote:
> fbnic derives the BDQ buffer layout from PAGE_SIZE. That decides at
> build time how a posted page is split into 4 KiB device pages, and
> uses the same completion decoding for HPQ and PPQ. That is wrong once
> the queues use different posted-page sizes; completions must be
> decoded with the geometry of the queue that produced them.
> 
> Keep PAGE_SIZE as the posted-page size for both queues in this change,
> so the descriptor format and runtime behavior stay unchanged.
> 
> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxx>
> Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_csr.h   | 34 ++------
>  .../net/ethernet/meta/fbnic/fbnic_debugfs.c   |  5 +-
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.c  | 83 ++++++++++++-------
>  drivers/net/ethernet/meta/fbnic/fbnic_txrx.h  |  6 ++
>  4 files changed, 72 insertions(+), 56 deletions(-)

Reviewed-by: Joe Damato <joe@xxxxxxx>