Re: [PATCH v3 3/3] mux: Avoid use-after-free of args.fwnode in mux_get()
From: Fabio
Date: Wed Sep 30 2026 - 14:11:26 EST
Hi Alvin,
On 30/09/26 11:45, Alvin Šipraga wrote:
I meant to suggest that you apply this fix before your fwnode patch, so
that it can be applied to the stable trees. Since you put the fix
afterwards, it either needs backporting, or the fwnode patch needs to be
carried too.
You might also want a Fixes: tag for it to actually get picked up for
stable.
Up to Peter though - it's a minor bug and the kernel has tons of such
refcounting bloopers. As far as the code is concerned it looks fine
(minor nit below). Thanks!
thank you so much for your patience, and mentoring. This is my first serious
contribution, so it's easy to slip on such bureaucratic considerations, and to neglect
forward thinking. Another tag I could use is Suggested-by, since you were the one spotting
the bug.
For now, I'm inclined to wait for Peter's response as I don't want to flood the mailing
list with another revision for a minor improvement. Should anybody explicitly request the
fix you suggested, or should nobody reply within a week or so, I'll go ahead and submit v4.
Cheers,
Fabio.