Re: [PATCH 3/8] iio: adc: rzt2h: Add chip-specific configuration

From: Lad, Prabhakar

Date: Wed Sep 30 2026 - 14:44:05 EST


Hi Andy,

Thank you for the review.

On Wed, Sep 30, 2026 at 10:26 AM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Sep 29, 2026 at 01:42:43PM +0100, Prabhakar wrote:
>
> > Prepare the driver for supporting SoCs with ADC IP that is similar to the
> > RZ/T2H ADC but may have different channel configurations.
> >
> > Introduce chip-specific configuration for the channel template and number
> > of channels, and use it when setting up the IIO channels and DMA layout.
>
> ...
>
> > +struct rzt2h_adc_chip_info {
> > + const struct iio_chan_spec *chan_template;
>
> __counted_by_ptr() ?
>
I don't think __counted_by_ptr() applies here. chan_template points to
a single struct iio_chan_spec, not to an array of num_channels
entries.

> > + unsigned int num_channels;
> > + u8 features;
> > +};
>
> ...
>
> > + chip_info = device_get_match_data(dev);
> > + if (!chip_info)
> > + return -ENODEV;
>
> -ENODATA
>
Ok.

Cheers,
Prabhakar