Re: [PATCH net-next] net: macb: move printk() calls out of bp->lock critical section

[Théo Lebrun]

Hello netdev bot,

On Wed Sep 30, 2026 at 8:38 PM CEST,  wrote:
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
>  - How the issue was discovered, e.g. hit in production, hit during
>    development, syzbot report, manual code inspection, LLM or static
>    analysis tool scan.

This is mentioned two fold; in the commit message:

   The netconsole deadlock is theoretical & never reproduced.

And in the cover letter (folded below the '--' line):

   Technically it is a fix, in practice I'm happy for it to go through
   net-next/main for more testing and it is a theoretical bugfix (as usual
   nowadays). Decided after seeing Jakub taking a similar patch into
   net-next this morning:
   [...]

>  - What hardware the change was tested on. For driver fixes please
>    mention the device (and if relevant firmware version) used for
>    testing, or say that the change was not tested on real hardware.

I do most of my MACB tests on EyeQ5.

> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.

I love this newly introduced message!
But here it might have been a false positive (?).

 - Can it read what's below the '--' line?

 - Maybe it could trust the driver maintainers, especially regarding the
   second question about having access to real hardware?

I looked around to see if this infra was open-source but I couldn't find
it. Only found the https://github.com/linux-netdev/nipa repo but that's
not it.

Thanks,

--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com