Re: [PATCH v2] x86,fs/resctrl: Add event group descriptions for Intel Diamond Rapids

[Reinette Chatre]

Hi Tony,

On 9/29/26 10:18 AM, Tony Luck wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/intel_aet.c b/arch/x86/kernel/cpu/resctrl/intel_aet.c
> index c22c3cf5167d..3555b0aa33ce 100644
> --- a/arch/x86/kernel/cpu/resctrl/intel_aet.c
> +++ b/arch/x86/kernel/cpu/resctrl/intel_aet.c

...

> +/*
> + * Link: https://github.com/intel/Intel-PMT/blob/main/xml/DMR/OOBMSM/RMID-PERF/dmr_aggregator.xml
> + */
> +static struct event_group perf_0x1415910A = {
> +	.pfname		= "perf",
> +	.guid		= 0x1415910A,
> +	.num_rmid	= 256,
> +	.mmio_size	= XML_MMIO_SIZE(256, 4, 3),
> +	.num_events	= 4,
> +	.evts		= {
> +		EVT(PMT_EVENT_UNHALTED_REF_CYCLES, 0, 0),
> +		EVT(PMT_EVENT_UNHALTED_CORE_CYCLES, 1, 0),
> +		EVT(PMT_EVENT_INST_RETIRED, 2, 0),
> +		EVT(PMT_EVENT_PCNT, 3, 0),
> +	}
> +};
> +
>  static struct event_group *known_event_groups[] = {
>  	&energy_0x26696143,
> +	&energy_0x47903099,
>  	&perf_0x26557651,
> +	&perf_0x1415910A,
>  };
>  

I asked our internal AI to take a look and it pointed out that this is
the first GUID with a character hex digit. Having the GUID be uppercase
makes diagnostics a bit harder because all messages print GUIDs with
lowercase:

	pr_warn("Bad package %u in guid 0x%x\n", tr->plat_info.package_id,
		tr->guid);
	pr_warn("MMIO space wrong size (%zu bytes) for guid 0x%x. Expected %zu bytes.\n",
		tr->size, e->guid, e->mmio_size);
	pr_info("No events enabled in %s %s:0x%x\n", r->name, e->pfname, e->guid);
	pr_info("%s %s:0x%x monitoring detected\n", r->name, e->pfname, e->guid);

Going from log message to source code is thus not "grep friendly". This is
a valid point.

With event_group name and its guid value switched to lower case
| Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reinette