Re: [PATCH v1 2/2] soc: starfive: Add JHB100 UART Routing driver

From: Linus Walleij

Date: Wed Sep 30 2026 - 19:29:32 EST


Hi Changhuang,

On Sat, Sep 19, 2026 at 12:55 PM Changhuang Liang
<changhuang.liang@xxxxxxxxxxxxxxxx> wrote:
>
> Hi, Linus
>
> Thank you for your feedback.
>
> > On Thu, Sep 3, 2026 at 11:32 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> > wrote:
> >
> > > Anyway, as you pointed out there is already one code like this -
> > > Aspeed
> > > - thus this is a second one and that makes it reasonable to make a
> > > proper common user-space API.
> >
> > Brrr my stance as pin control mainainer is that this was merged behind my
> > back and shouldn't have been done like that, and two wrongs does not XOR
> > and make one right.
> >
> > I think what we want here is a way to flag some specific pinctrl states as
> > userspace accessible and develop an ABI for that.
>
> In this series, I have organized v2 and sorted out a common interface for Aspeed and Starfive:
> https://lore.kernel.org/all/20260905102901.126035-1-changhuang.liang@xxxxxxxxxxxxxxxx/
>
> This new series does not affect the previous usage. I am not yet sure how to implement this
> functionality in pinctrl.

It's pretty clear how to implement this in pinctrl, just like I said:
a userspace ABI for pin control states.

No-one knows how that should look, it would need to be invented
from that point.

Probably something in sysfs.

But if another subsystem is going to deal with it, I will not complain.

Yours,
Linus Walleij