Re: [PATCH] ACPI: GED: Support GpioInt event resources

From: Linus Walleij

Date: Wed Sep 30 2026 - 19:34:38 EST


On Wed, Sep 30, 2026 at 1:16 PM Rahul Pon <theflyingrahul@xxxxxxxxx> wrote:

> The Generic Event Device accepts only Interrupt and ExtendedInterrupt
> resources in _CRS. Some ACPI firmware signals GED events through GPIO
> controllers instead: the HP OmniBook 5 16-bf1xxx (Snapdragon X2) describes
> its lid (LIGE) and embedded-controller event device (ECGE) as ACPI0013 with
> GpioInt resources, and both currently fail to probe with "unable to parse
> IRQ resource".
>
> Handle GpioInt resources: get the Linux IRQ with acpi_dev_gpio_irq_get(),
> which applies the trigger and polarity and returns -EPROBE_DEFER until the
> GPIO controller is registered, and evaluate _EVT with the GPIO pin number,
> as done for GSIs above 255. GpioIo resources are skipped. On a failed walk,
> free the events already requested and propagate the GPIO error (including
> -EPROBE_DEFER) instead of -EINVAL.
>
> Tested on the HP OmniBook 5 16-bf1xxx: lid close/open run _EVT and reach
> the ACPI button driver and logind.
>
> Assisted-by: LLM
> Signed-off-by: Rahul Pon <theflyingrahul@xxxxxxxxx>

I don't understand the patch at all, but I understand that Andy or Mika must
review it otherwise it's not going anywhere, so looping them in.

Yours,
Linus Walleij