Re: (subset) [PATCH v5 00/42] clk: qcom: Tie CX power domains to GCCs

[Bjorn Andersson]

On Tue, Sep 29, 2026 at 04:50:53PM -0500, Rob Herring wrote:
> On Fri, Sep 25, 2026 at 11:43 AM Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
> >
> >
> > On Thu, 24 Sep 2026 13:39:16 +0300, Abel Vesa wrote:
> > > Tie the CX power domain to GCC clock controllers for SDM670,
> > > SM8150, SM8250, SM8350, SM8450, SM8550, SM8650, SM8750, SM6350,
> > > SM4450, QCS8300, SDX75, SAR2130P, SC7180, SC7280, SA8775P,
> > > X1E80100, Eliza, Kaanapali, and QCS615.
> > >
> > > Enable runtime PM for GCC providers without critical clocks, allowing CX to
> > > power down when their consumers release clocks and GDSCs.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [01/42] dt-bindings: clock: qcom: gcc-sdm845: Require CX power domain
> >         commit: 55388f587b3301dffdb30074d00f069d80d29341
> > [02/42] dt-bindings: clock: qcom: gcc-sm8150: Add CX power domain
> >         commit: 80d35f528a46b5f1e9777ce83de48fd9efa7c422
> > [03/42] dt-bindings: clock: qcom: gcc-sm8250: Add CX power domain
> >         commit: 98e936c9d46a25b4eceacf907fe5d87b3999040e
> > [04/42] dt-bindings: clock: qcom: gcc-sm8350: Add CX power domain
> >         commit: 534af057998b59a4813fd2eba524f2f523f356d6
> > [05/42] dt-bindings: clock: qcom: gcc-sm8450: Add CX power domain
> >         commit: 4de0860a340888fd2582681facbceda71b375617
> > [06/42] dt-bindings: clock: qcom: qcs615-gcc: Add CX power domain
> >         commit: 779dd957c4c8a7d7d0fd8ac03caa27fe6db23514
> > [07/42] dt-bindings: clock: qcom: sm8550-gcc: Add CX power domain
> >         commit: 5a577a480dd3d764cc2f55a112efc92d59ad59ec
> > [08/42] dt-bindings: clock: qcom: sm8650-gcc: Add CX power domain
> >         commit: 76615e10462c425f926e50dce52e9d23bb2f9428
> > [09/42] dt-bindings: clock: qcom: sm8750-gcc: Add CX power domain
> >         commit: f9c74b6ed57922b1fdb1ed6835665e06b5ba01a5
> > [10/42] dt-bindings: clock: qcom: sm4450-gcc: Add CX power domain
> >         commit: df3faa0e74e433304f9a6f33d3ac4d3376fcdc06
> > [11/42] dt-bindings: clock: qcom: gcc-sm6350: Add CX power domain
> >         commit: 3d4f3414300bba79d517585ac10181e285ca6be3
> > [12/42] dt-bindings: clock: qcom: qcs8300-gcc: Add CX power domain
> >         commit: fcf1810fede27777f9b708a9cef431bcac1d8e38
> > [13/42] dt-bindings: clock: qcom: sdx75-gcc: Add CX power domain
> >         commit: 6df1fd0bfa649c0f13abd026a01dbed5f1727fea
> > [14/42] clk: qcom: gcc-eliza: Tie the CX power domain to controller
> >         commit: 4eb8f2ad36888e5b29aa0a5e7e0bc60e382312ea
> > [15/42] clk: qcom: gcc-kaanapali: Tie the CX power domain to controller
> >         commit: 18c75784e4a9db5ed8cf6818a29ec0ac15ea2c8b
> > [16/42] clk: qcom: gcc-qcs8300: Tie the CX power domain to controller
> >         commit: 2d948e428c77b8764fe96537c70e5500b29f9c4e
> > [17/42] clk: qcom: gcc-sa8775p: Tie the CX power domain to controller
> >         commit: eed0a644a28a39d9da91a10d51b8f3247302a533
> > [18/42] clk: qcom: gcc-sar2130p: Tie the CX power domain to controller
> >         commit: 40537977a0ff9a6a1bcc489863e5656914b1ac53
> > [19/42] clk: qcom: gcc-sc7280: Tie the CX power domain to controller
> >         commit: 503de100eb2823519b82d759ead69ee377289a9e
> > [20/42] clk: qcom: gcc-sdx75: Tie the CX power domain to controller
> >         commit: 563b9aceb53ea15f2ada9417809d1d9e9a2c1fd1
> > [21/42] clk: qcom: gcc-sm4450: Tie the CX power domain to controller
> >         commit: 9965e30e827665e2fc9f0b3271733feaee809d48
> > [22/42] clk: qcom: gcc-sm8350: Tie the CX power domain to controller
> >         commit: 4572e9c0c4d48447d22a25037cbd2fbfda74a8c2
> > [23/42] clk: qcom: gcc-sm8450: Tie the CX power domain to controller
> >         commit: 6742c3ce04e5d52f718e4b562d0a1d817e1d76db
> > [24/42] clk: qcom: gcc-sm8550: Tie the CX power domain to controller
> >         commit: fe2a50974f4a0c78a68931f156d99e0479a4f00a
> > [25/42] clk: qcom: gcc-sm8650: Tie the CX power domain to controller
> >         commit: e4e6177235c6e0342357c48497d6b1a546c0ae57
> > [26/42] clk: qcom: gcc-sm8750: Tie the CX power domain to controller
> >         commit: f593d28a9193f1b5a96eb69bc5eb4dda2eaebebf
> > [27/42] clk: qcom: gcc-x1e80100: Tie the CX power domain to controller
> >         commit: 965dd2be7d35b2474251ee60d44addb257c9c85f
> 
> Pretty sure this has introduced a bunch of warnings for qcom. Where's
> the .dts changes?
> 

My bad. I test every dts change against the current bindings in
linux-next, but not the other way around - so I failed to spot the
introduced warnings.

> We've really got to stop merging binding changes that introduce
> warnings to existing .dts files.
> 

Warnings we can fix, the possible regressions in backwards compatibility
is a bigger concern to me. So that's another pass I need to figure out
how to incorporate in my workflow.

Regards,
Bjorn

>      14 clock-controller@100000 (qcom,sm8550-gcc): 'power-domains' is
> a required property
>      12 syscon@9a10000 (syscon): compatible: ['syscon'] is too short
>      11 clock-controller@100000 (qcom,gcc-sm8250): 'power-domains' is
> a required property
>       9 clock-controller@100000 (qcom,qcs8300-gcc): 'power-domains' is
> a required property
>       8 clock-controller@100000 (qcom,sm8650-gcc): 'power-domains' is
> a required property
>       8 clock-controller@100000 (qcom,qcs615-gcc): 'power-domains' is
> a required property
>       6 clock-controller@100000 (qcom,gcc-sm8150): 'power-domains' is
> a required property
>       5 clock-controller@100000 (qcom,gcc-sm8450): 'power-domains' is
> a required property
>       5 clock-controller@100000 (qcom,gcc-sm8350): 'power-domains' is
> a required property
>       2 clock-controller@100000 (qcom,sm8750-gcc): 'power-domains' is
> a required property
>       2 clock-controller@100000 (qcom,kaanapali-gcc): 'power-domains'
> is a required property
>       2 clock-controller@100000 (qcom,gcc-sm6350): 'power-domains' is
> a required property
>       2 clock-controller@100000 (qcom,gcc-sdm670): 'power-domains' is
> a required property
>       1 clock-controller@80000 (qcom,sdx75-gcc): 'power-domains' is a
> required property
>       1 clock-controller@100000 (qcom,sm4450-gcc): 'power-domains' is
> a required property
> 
> 
> Rob