Re: [PATCH v2] staging: octeon: fix function declaration formatting

From: Greg Kroah-Hartman

Date: Thu Oct 01 2026 - 01:24:07 EST


On Fri, Aug 21, 2026 at 11:04:09AM -0300, Tiago Panizio Gottardo wrote:
> Move the cvm_oct_of_get_child() return type to a separate line and keep
> the function name with its arguments.
>
> No functional changes intended.
>
> Signed-off-by: Tiago Panizio Gottardo <tiago.panizio@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Split out one focused formatting cleanup.
> - Dropped RGMII formatting and parentheses changes.
> - Dropped unrelated alignment cleanups.
>
> drivers/staging/octeon/ethernet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 42ec4b8324a8..e668e3baaa31 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -621,8 +621,8 @@ static const struct net_device_ops cvm_oct_pow_netdev_ops = {
> #endif
> };
>
> -static struct device_node *cvm_oct_of_get_child
> - (const struct device_node *parent, int reg_val)
> +static struct device_node *
> +cvm_oct_of_get_child(const struct device_node *parent, int reg_val)
> {
> struct device_node *node;
> const __be32 *addr;

No, the original should be just fine, thanks.

greg k-h