Re: [PATCH v2] staging: rtl8723bs: return bool from check_pending_xmitbuf

[Greg Kroah-Hartman]

> check_pending_xmitbuf() returns only true or false. Use bool as its
> return type to accurately describe the function's behavior.
> 
> Signed-off-by: Matheus Alves de Almeida <matheus.aalmeida@xxxxxxxxxxxx>
> Link: https://patch.msgid.link/20260919210645.25796-1-matheus.aalmeida@xxxxxxxxxxxx
> ---
> Changes in v2:
> - Add missing "staging: " prefix to commit message
> 
>  drivers/staging/rtl8723bs/core/rtw_xmit.c    | 4 ++--
>  drivers/staging/rtl8723bs/include/rtw_xmit.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 95350fd6a94f..634320e53aab 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -2469,10 +2469,10 @@ struct xmit_buf *dequeue_pending_xmitbuf_under_survey(struct xmit_priv *pxmitpri
>  	return pxmitbuf;
>  }
>  
> -signed int check_pending_xmitbuf(struct xmit_priv *pxmitpriv)
> +bool check_pending_xmitbuf(struct xmit_priv *pxmitpriv)

Shouldn't you also change the place where this is called to take a bool
as well?

thanks,

greg k-h

-- 
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>