Re: [PATCH 3/4] ARM: dts: imx6: phycore-som: Convert to generic PHY reset binding

[Primoz Fiser]

Hi Frank,

On 9/30/26 17:50, Frank Li wrote:
> On Wed, Sep 30, 2026 at 12:25:31PM +0200, Primoz Fiser wrote:
>> The phy-reset-gpios property on the FEC node is deprecated by the
>> Documentation/devicetree/bindings/net/fsl,fec.yaml in favour of the
>> generic reset binding on the PHY node itself, described by the
>> Documentation/devicetree/bindings/net/ethernet-phy.yaml.
>>
>> Move the reset GPIO from &fec to the ethphy child node as reset-gpios.
> 
> This movement may impact back compatiblity. Any other user use
> phy-reset-gpios under $fec?

Yeah, good point.

I was tempted to convert due to checkpatch warning.

Since it's a legacy board, lets keep phy-reset-gpios as is due to
potential backward compatibility and other unforeseen implications.

I will drop this patch in v2 and convert patch #4 to phy-reset-duration.

BR,

Primoz

> 
> Frank
> 
>>
>> Signed-off-by: Primoz Fiser <primoz.fiser@xxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
>> index 9070388eecb0..88eabc7af6b7 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
>> @@ -56,7 +56,6 @@ &fec {
>>  	phy-handle = <&ethphy>;
>>  	phy-mode = "rgmii";
>>  	phy-supply = <&vdd_eth_io>;
>> -	phy-reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>>  	status = "disabled";
>>
>>  	mdio {
>> @@ -65,6 +64,7 @@ mdio {
>>
>>  		ethphy: ethernet-phy@3 {
>>  			reg = <3>;
>> +			reset-gpios = <&gpio1 14 GPIO_ACTIVE_LOW>;
>>  			txc-skew-ps = <1680>;
>>  			rxc-skew-ps = <1860>;
>>  		};
>> --
>> 2.34.1
>>
>>

-- 
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@xxxxxxxxx
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@xxxxxxxxx