Re: [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc

From: Viresh Kumar

Date: Thu Oct 01 2026 - 02:12:15 EST


On 12-09-26, 00:14, Karl Mehltretter wrote:
> dev_pm_opp_get_of_node() returns NULL when the OPP is invalid, but its
> kernel-doc says "else 0 on success", which was never true. Say NULL.
>
> Fixes: e2f4b5f8dc59 ("PM / OPP: Implement dev_pm_opp_get_of_node()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@xxxxxxxxx>
> ---
> drivers/opp/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 2f3bbde9a9e1742a2d6b40be91a65d8fa7365bf3..ea93800795783f0595483742c0c10de42b25518a 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -1409,7 +1409,7 @@ bool dev_pm_opp_of_has_required_opp(struct device *dev)
> * dev_pm_opp_get_of_node() - Gets the DT node corresponding to an opp
> * @opp: opp for which DT node has to be returned for
> *
> - * Return: DT node corresponding to the opp, else 0 on success.
> + * Return: DT node corresponding to the opp, else NULL.
> *
> * The caller needs to put the node with of_node_put() after using it.
> */

Applied. Thanks.

--
viresh