Re: [PATCH v17 1/6] spi: pxa2xx: rename local status variable to ret

[Andy Shevchenko]

On Thu, Oct 01, 2026 at 12:06:24AM +0800, Shih-Yuan Lee wrote:
> Rename the return value variable name from 'status' to 'ret' in the
> pxa2xx_spi_probe(), pxa2xx_spi_suspend(), and pxa2xx_spi_resume()
> functions to conform to standard Linux kernel coding conventions.
> 
> Assisted-by: Antigravity:gemini-3.8-flash sparse

Assisted-by: LLM

...

> -	status = request_irq(ssp->irq, ssp_int, IRQF_SHARED, dev_name(dev),
> +	ret = request_irq(ssp->irq, ssp_int, IRQF_SHARED, dev_name(dev),
>  			drv_data);

Also fix the indentation of the second line. Actually just join them to become
a single line.

> -	if (status < 0)
> -		return dev_err_probe(dev, status, "cannot get IRQ %d\n", ssp->irq);
> +	if (ret < 0)
> +		return dev_err_probe(dev, ret, "cannot get IRQ %d\n", ssp->irq);

...

>  		drv_data->gpiod_ready = devm_gpiod_get_optional(dev,
>  						"ready", GPIOD_OUT_LOW);
>  		if (IS_ERR(drv_data->gpiod_ready)) {
> -			status = PTR_ERR(drv_data->gpiod_ready);
> +			ret = PTR_ERR(drv_data->gpiod_ready);
>  			goto out_error_clock_enabled;
>  		}

Actually this can be redone as

		ret = PTR_ERR_OR_ZERO(drv_data->gpiod_ready);
		if (ret)
			goto out_error_clock_enabled;

-- 
With Best Regards,
Andy Shevchenko