Re: [PATCH 2/2] hwmon: (tps38900x) Add driver for TI TPS389004/TPS389006/TPS389008

From: Krzysztof Kozlowski

Date: Thu Oct 01 2026 - 04:20:11 EST


On Tue, Sep 29, 2026 at 04:04:05PM -0700, Luna Hart wrote:
> +static const struct i2c_device_id tps38900x_id[] = {
> + { .name = "tps389004", .driver_data = 4 },
> + { .name = "tps389006", .driver_data = 6 },
> + { .name = "tps389008", .driver_data = 8 },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, tps38900x_id);
> +
> +static const struct of_device_id tps38900x_of_match[] = {
> + { .compatible = "ti,tps389004", .data = (void *)4 },
> + { .compatible = "ti,tps389006", .data = (void *)6 },
> + { .compatible = "ti,tps389008", .data = (void *)8 },

Does this mean programming model is exactly the same for all of them,
just additional channels?

If so, then these could be made compatible in the binding - use
fallback, to the ti,tps389004. I don't insist, though.

Best regards,
Krzysztof