Re: [PATCH v6 3/5] perf report: Add --no-progress option

[Arnaldo Carvalho de Melo]

On Thu, Oct 01, 2026 at 12:01:25AM -0700, Namhyung Kim wrote:
> On Wed, Sep 30, 2026 at 11:37:14PM +0200, Arnaldo Carvalho de Melo wrote:
> > +++ b/tools/perf/builtin-report.c
> > @@ -88,6 +88,7 @@ struct report {
> >  #endif
> >  	bool			use_stdio;
> >  	bool			progress;
> > +	bool			progress_set;
> >  	bool			show_full_info;
> >  	bool			show_threads;
> >  	bool			inverted_callchain;
> > @@ -1385,8 +1386,15 @@ int cmd_report(int argc, const char **argv)
> >  		    "Use the stdio interface"),
> >  	OPT_BOOLEAN(0, "weights", &symbol_conf.annotate_weight,
> >  			"Show or hide weight columns in annotation. Default show if non-zero."),
> > -	OPT_BOOLEAN(0, "progress", &report.progress,
> > -		    "Show progress while processing the perf.data file"),
> > +	/*
> > +	 * No --no-progress option to add: parse-options provides it as
> > +	 * the negation of this one, clearing report.progress, which is
> > +	 * also how it starts out.  progress_set is what tells the hook
> > +	 * below to stop the TUI and GTK browsers as well, they show
> > +	 * progress until asked not to.
> > +	 */
 
> Nit: I think we can drop this comment.
 
> > @@ -1796,9 +1804,13 @@ int cmd_report(int argc, const char **argv)
> >  	/*
> >  	 * For the stdio case: print the percentage of the perf.data file
> >  	 * processed so far for each processing phase.  --quiet asks for no
> > -	 * messages at all, so it leaves the phases uncounted.
> > +	 * messages at all, so it leaves the phases uncounted, and
> > +	 * --no-progress, progress_set with progress cleared, turns off what
> > +	 * the TUI and GTK browsers show as well.
> >  	 */
 
> Maybe this one too..

Will drop both.

- Arnaldo