Re: [PATCH] staging: rtl8723bs: make rtl8723_dequeue_writeport() return bool

[Greg Kroah-Hartman]

On Sat, Sep 26, 2026 at 10:58:27AM +0000, Hungyu Lin wrote:
> rtl8723_dequeue_writeport() returns boolean state and its caller uses the
> return value as a boolean.
> 
> Change the return type to bool and replace _FAIL with false. Also use bool
> for the caller's queue_empty variable.
> 
> No functional change.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@xxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> index 0441e84ea87d..482dd1baf3ca 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c
> @@ -33,7 +33,7 @@ static u8 rtw_sdio_wait_enough_TxOQT_space(struct adapter *padapter, u8 agg_num)
>  	return true;
>  }
>  
> -static s32 rtl8723_dequeue_writeport(struct adapter *padapter)
> +static bool rtl8723_dequeue_writeport(struct adapter *padapter)

Please change the variable that is assigned to the output of this
function as well.

thanks,

greg k-h