Re: [PATCH] staging: greybus: add missing newlines in sysfs_emit formats

From: Greg Kroah-Hartman

Date: Thu Oct 01 2026 - 05:47:05 EST


On Sat, Sep 26, 2026 at 02:23:28AM +0530, Ashutosh Yadav wrote:
> According to Documentation/filesystems/sysfs.rst, sysfs attribute show
> functions should output a single value and terminate with a newline.
>
> Currently, gb_audio_module_name_show(), gb_audio_module_vid_show(),
> gb_audio_module_pid_show(), gb_audio_module_intf_id_show(),
> gb_audio_module_ip_devices_show(), and gb_audio_module_op_devices_show()
> call sysfs_emit() without a trailing newline in their format strings.
>
> Add the missing newline character to each sysfs_emit() format string to
> comply with the sysfs documentation and silence checkpatch warnings.
>
> Signed-off-by: Ashutosh Yadav <yadavxashutosh@xxxxxxxxx>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Please read the archives for why this patch keeps getting rejected :)

thanks,

greg k-h