Re: [PATCH v2 0/3] rtc: ftrtc010: fix resource management and integer overflow
From: Alexandre Belloni
Date: Thu Oct 01 2026 - 06:05:45 EST
On Thu, 27 Aug 2026 16:03:17 +0800, Liu Dalin wrote:
> This series fixes three issues in the Faraday FTRTC010 RTC driver
> found by Sashiko AI static analysis:
>
> Patch 1: Fixes a clock resource leak when devm_rtc_register_device()
> fails in ftrtc010_rtc_probe().
>
> Patch 2: Replaces manual clock management with devm APIs to fix a
> use-after-disable vulnerability in ftrtc010_rtc_remove(). The RTC
> device is registered via devm_rtc_register_device() but clocks are
> manually disabled in .remove() before devres cleanup, creating a
> window where MMIO reads on clock-gated hardware can cause a
> synchronous external abort.
>
> [...]
Applied, thanks!
[1/3] rtc: ftrtc010: fix clock resource leak on probe failure
https://git.kernel.org/abelloni/c/c60478875a44
[2/3] rtc: ftrtc010: use devm clock APIs to fix use-after-disable in remove
https://git.kernel.org/abelloni/c/d41ee317c990
[3/3] rtc: ftrtc010: fix integer overflow in time calculation
https://git.kernel.org/abelloni/c/8ef8e9839a23
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com