Re: [PATCH v2] spi: cs42l43: Workaround for wrong speaker ID on Dell XPS 13 DX13260

[Charles Keepax]

On Thu, Oct 01, 2026 at 09:58:30AM +0100, Richard Fitzgerald wrote:
> On Dell XPS 13 DX13260 create an acpi_gpio_mapping with exactly two
> GPIO entries to point at the two pins in the GpioIo(). Use this to
> read the speaker ID GPIOs.
> 
> This fixes problems on Dell XPS 13 DX13260:
> 
> - No speaker audio
> - The wrong firmware was loaded so the speaker protection did not match
>   the speaker characteristics.
> 
> The Dell XPS 13 DX13260 has two speaker ID GPIOs, to form a 2-bit ID. The
> ACPI GpioIo() has both pins but the Linux-specific spk-id-gpios property
> only has a mapping to the first pin. This meant that the speaker ID was
> wrong in most cases, and that would lead to the codec driver loading the
> wrong amp firmware, or not finding a firmware (as 0 is not a valid ID on
> this laptop).
> 
> Assisted-by: Codex:gpt-6-sol
> Reported-by: Wiza Jalakasi <wjalakasi@xxxxxxxxx>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221956
> Tested-by: Wiza Jalakasi <wjalakasi@xxxxxxxxx>
> Fixes: f3c605147741e ("spi: cs42l43: Add GPIO speaker id support to the bridge configuration")
> Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles