Re: [PATCH v3] staging: rtl8723bs: return bool from check_pending_xmitbuf

From: Dan Carpenter

Date: Thu Oct 01 2026 - 06:39:46 EST


On Thu, Oct 01, 2026 at 07:04:41AM -0300, Matheus Alves de Almeida wrote:
> @@ -2482,7 +2482,7 @@ signed int check_pending_xmitbuf(struct xmit_priv *pxmitpriv)
>
> int rtw_xmit_thread(void *context)
> {
> - s32 err;
> + bool err;

err should never be bool in the kernel. It should be int or ssize_t.
Same thing for ret ideally. Pick a better name or people will think
"ret" is a normal "ret".

> struct adapter *padapter;
>
> err = _SUCCESS;
^^^^^^^^^^^^^^

regards,
dan carpenter