Re: [PATCH v2] media: rcar-isp: ispcore: Fix inconsistent step sizes

From: Sakari Ailus

Date: Thu Oct 01 2026 - 06:46:38 EST


Hi Barnabás,

On Thu, Oct 01, 2026 at 10:51:30AM +0200, Barnabás Pőcze wrote:
> `risp_io_{input,capture}_enum_framesizes()` sets the horizontal and vertical
> step size to 2. However, `risp_io_{input,capture}_try_format()` passes 2
> to `v4l_bound_align_image()`, which corresponds to a step size of 2^2 = 4.
>
> So move these constants into macros to avoid the repetition, and with that,
> use 4 as the step size everywhere.
>
> Fixes: 2151350f60d1 ("media: rcar-isp: Add support for ISPCORE")
> Signed-off-by: Barnabás Pőcze <barnabas.pocze+renesas@xxxxxxxxxxxxxxxx>
> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

I already have v1 in my tree and I don't think there's a need to fix that
tiny typo just for the typo itself.

--
Regards,

Sakari Ailus