Re: [PATCH] staging: greybus: audio_manager_module: Add missing newlines to sysfs_emit() formats
From: Greg KH
Date: Thu Oct 01 2026 - 08:32:05 EST
On Thu, Oct 01, 2026 at 05:43:48PM +0530, Ronit Gupta wrote:
> According to Documentation/filesystems/sysfs.rst, sysfs attribute values
>
> should terminate with a single newline character.
> Add missing trailing '\n' characters to the format strings of all
>
> sysfs_emit() calls in gb_audio_module_*_show() attribute callbacks.
>
> Signed-off-by: Ronit Gupta <ronitgupta138@xxxxxxxxx>
>
> ---
>
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
>
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_module.c
> b/drivers/staging/greybus/audio_manager_module.c
> index dc90cc2d2..5737f2a32 100644
>
> --- a/drivers/staging/greybus/audio_manager_module.c
>
> +++ b/drivers/staging/greybus/audio_manager_module.c
>
> @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject
> *kobj)
> static ssize_t gb_audio_module_name_show(struct
> gb_audio_manager_module *module,
<snip>
Something went really wrong here, please take a look at the email
documentation in the kernel for more details on how to do this properly.
thanks,
greg k-h