Re: [PATCH v3 10/18] KVM: arm64: Handle PSCI calls for protected VMs at EL2
From: Fuad Tabba
Date: Thu Oct 01 2026 - 09:27:35 EST
Hi Will,
On Thu, 01 Oct 2026 13:58:01 +0100, Will Deacon <will@xxxxxxxxxx> wrote:
[...]
> For the benefit of everybody else, we had a fire alarm in the office
> yesterday evening so Fuad and I sat outside a bar with a beer and a
> piece of paper and went through this together...
Memory ordering is hard work...
[...]
> If we address (2), then I think the sequence becomes a little easier to
> reason about. The OFF->ON_PENDING transition on the requestor looks
> like:
[...]
> which I think makes sense. WDYT? If you agree, I wonder if we can
> include a comment similar to the above in the code?
Agreed, and thanks for going through it with me (and for the beer!).
v4 already clears reset on the CPU_OFF path rather than on guest
entry, and I'll add your sequence as a comment above
pkvm_reset_vcpu().
Cheers,
/fuad