Re: [PATCH net-next v2 1/7] dt-bindings: net: mediatek-dwmac: add support for MT8189 SoC

[Louis-Alexis Eyraud]

Hi Krzysztof,

On Tue, 2026-09-29 at 09:36 +0200, Krzysztof Kozlowski wrote:
> On Thu, Sep 24, 2026 at 09:23:24AM +0200, Louis-Alexis Eyraud wrote:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - mediatek,mt8189-gmac
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: MAC Main clock
> > +            - description: PTP clock
> 
> snps,dwmac schema expects the second clock to be the pclk. Why is it
> missing? This should be explained in the commit msg.
> 
> Best regards,
> Krzysztof
> 
Indeed, there is something incorrect.

I looked again at the MT8189 datasheets and there does not seem to have
specific peripheral clock for Ethernet MAC in the SoC clock list. The
paragraph related to clocks also lists the mac main and ptp reference
clocks as the ones to turn on. There is also another RMII reference
clock, only needed for RMII case, but I removed from mt8189 clock list
in the bindings after v1 review ([1]).

But at the same time, the Ethernet MAC block diagram, present in the
datasheets, shows this IP is interconnected to the rest of SoC with AXI
and APB interfaces (and in MT8188 datasheet too).
There is no APB related clock that is specific to the IP in MT8189,
contrary to MT8188 or MT819. But since it is on an APB bus (likely
shared between multiple IPs), then there is a bus clock for peripheral
access. Describing the IP having it makes sense (and for AXI too).

So, in order to resolve this issue, would it be OK that I rework the
MT8189 clock list to add "axi" and "apb" clocks and reword the commit
message with additional details on clocks?

[1]:
https://lore.kernel.org/all/b810b9cd-8f5e-4c9d-8496-908aae55dac1@xxxxxxx/

Best regards,
Louis-Alexis