Re: [PATCH net-next] net: usb: asix: remove redundant PHY address short-read check
From: Simon Horman
Date: Thu Oct 01 2026 - 10:08:07 EST
On Mon, Sep 28, 2026 at 03:21:19PM -0400, Xinsheng Zhu wrote:
> Short-read handling was added to asix_read_cmd() by commit
> 920a9fa27e78 ("net: asix: add proper error handling of usb read errors").
> The helper converts short reads to -ENODATA while preserving negative
> errors from the underlying USB read operation.
>
> Remove the redundant short-read check in asix_read_phy_addr()
> and its unreachable -EIO assignment. The existing negative-return check
> handles both short reads and underlying USB read errors.
>
> Signed-off-by: Xinsheng Zhu <xinsheng.zhu.ny@xxxxxxxxx>
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>