Re: [PATCH] block: amiflop: synchronize flush timer before track flush
From: Jens Axboe
Date: Thu Oct 01 2026 - 11:02:46 EST
On Wed, 30 Sep 2026 14:59:51 +0800, Runyu Xiao wrote:
> The amiflop track buffer is shared with the timer callback. timer_delete()
> does not wait for an in-flight callback, and that callback can rearm itself
> when it cannot acquire the floppy controller. A synchronous track flush can
> therefore race with the callback.
>
> Stop the timer before synchronous track writes and use timer_delete_sync()
> to wait for any callback already running. Keep callback rearming disabled
> until the write is complete. Apply this to the FDFMTTRK path as well.
>
> [...]
Applied, thanks!
[1/1] block: amiflop: synchronize flush timer before track flush
commit: 9690943353cec1690a715e000ba6a74e5139f530
Best regards,
--
Jens Axboe