Re: [PATCH] i3c: renesas: Fix MDYAD(x) field length
From: Frank Li
Date: Thu Oct 01 2026 - 11:34:27 EST
On Thu, Oct 01, 2026 at 04:10:09PM +0100, Diogo Ivo wrote:
> Fix the length of the MDYAD(x) macro to be 7 bits as it represents an
> I3C address, which is 7 bits. The length of this field was confirmed on
> the documentation of the RZ/G3{E,L,S} SoCs.
>
> Fixes: d028219a9f148 ("i3c: master: Add basic driver for the Renesas I3C controller")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Diogo Ivo <diogo.ivo.sx@xxxxxxxxxxx>
> ---
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> drivers/i3c/master/renesas-i3c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/renesas-i3c.c b/drivers/i3c/master/renesas-i3c.c
> index 28c0927a0179..8b264f72e55c 100644
> --- a/drivers/i3c/master/renesas-i3c.c
> +++ b/drivers/i3c/master/renesas-i3c.c
> @@ -37,7 +37,7 @@
> #define BCTL_BUSE BIT(31)
>
> #define MSDVAD 0x18
> -#define MSDVAD_MDYAD(x) FIELD_PREP(GENMASK(21, 16), x)
> +#define MSDVAD_MDYAD(x) FIELD_PREP(GENMASK(22, 16), x)
> #define MSDVAD_MDYADV BIT(31)
>
> #define RSTCTL 0x20
>
> ---
> base-commit: 66b734f67a4a0a4c2313afb89033d5ab8b8f7523
> change-id: 20261001-divo-ssgrlpcsrc-2966-i3c_mdyad-0ba701c9add9
>
> Best regards,
> --
> Diogo Ivo <diogo.ivo.sx@xxxxxxxxxxx>
>
> ________________________________
>
> Renesas Electronics Europe GmbH
> Registered Office: Arcadiastrasse 10
> DE-40472 Duesseldorf
> Commercial Registry: Duesseldorf, HRB 3708
> Managing Director: Carsten Jauch
> VAT-No.: DE 14978647
> Tax-ID-No: 105/5839/1793
>
> Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.