Re: [PATCH bpf-next v2] bpf, cgroup: fix cgroup struct_ops query for a second attach type

From: patchwork-bot+netdevbpf

Date: Thu Oct 01 2026 - 12:12:31 EST


Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@xxxxxxxxxx>:

On Thu, 1 Oct 2026 07:19:01 -0700 you wrote:
> Two things in __cgroup_bpf_query() work only because CGROUP_TCP_SOCK_OPS is
> the only struct_ops attach type.
>
> It calls cgroup_bpf_enabled(atype) with an atype that
> find_atype_by_struct_ops_id() works out at runtime. That macro is an asm
> goto and needs a constant. Today the compiler can see there is only one
> value; add a second type and the build breaks with "impossible constraint
> in 'asm'". The check is not needed anyway. When the key is off nothing is
> attached, so progs[atype] and effective[atype] are empty and the count loop
> leaves total_cnt at 0. The other attach types already use that loop with
> no such check. Drop the check and the skip_count label.
>
> [...]

Here is the summary with links:
- [bpf-next,v2] bpf, cgroup: fix cgroup struct_ops query for a second attach type
https://git.kernel.org/bpf/bpf-next/c/b5a4aa31abd6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html