Re: [PATCH net-next v23 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Jakub Kicinski]

On Thu,  1 Oct 2026 03:45:13 +0800 Kyle Switch wrote:
> +	/* 100M template amplitude */
> +	ctrl = FIELD_PREP(YT8824_DAC_IMID_CH3_ORG, 0x45);
> +	ctrl |= FIELD_PREP(YT8824_DAC_IMID_CH2_ORG, 0x45);
> +	mask = YT8824_DAC_IMID_CH3_ORG | YT8824_DAC_IMID_CH3_ORG;

cocci says:

drivers/net/phy/motorcomm.c:1372:8-31: duplicated argument to & or |

Please also wait for the AI review to be published before reposting.
-- 
pw-bot: cr