[PATCH net-next 2/4] eth: mpnic: add a service task

[Daniel Zahka]

Add a service task that runs while the netdevice is running. For now,
the service task does nothing besides conditionally reschedule itself.

Signed-off-by: Daniel Zahka <daniel.zahka@xxxxxxxxx>
---
 drivers/net/ethernet/meta/mpnic/mpnic.h        |  3 +++
 drivers/net/ethernet/meta/mpnic/mpnic_netdev.c |  3 +++
 drivers/net/ethernet/meta/mpnic/mpnic_pci.c    | 17 +++++++++++++++++
 3 files changed, 23 insertions(+)

diff --git a/drivers/net/ethernet/meta/mpnic/mpnic.h b/drivers/net/ethernet/meta/mpnic/mpnic.h
index 78359ab6abb1..8b08af0fadcc 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic.h
+++ b/drivers/net/ethernet/meta/mpnic/mpnic.h
@@ -7,6 +7,7 @@
 #include <linux/interrupt.h>
 #include <linux/io-64-nonatomic-lo-hi.h>
 #include <linux/types.h>
+#include <linux/workqueue.h>
 
 #include "mpnic_csr.h"
 
@@ -27,6 +28,8 @@ struct mpnic_dev {
 
 	u32 __iomem *uc_addr0;
 
+	struct delayed_work service_task;
+
 	u16 num_irqs;
 
 	u64 dsn;
diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c b/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
index 2c0309d0c221..bd10df4a9d46 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_netdev.c
@@ -35,6 +35,8 @@ static int mpnic_open(struct net_device *netdev)
 	netif_tx_wake_all_queues(netdev);
 	netif_carrier_on(netdev);
 
+	schedule_delayed_work(&mpn->mpd->service_task, HZ);
+
 	return 0;
 
 err_free_resources:
@@ -48,6 +50,7 @@ static int mpnic_stop(struct net_device *netdev)
 {
 	struct mpnic_net *mpn = netdev_priv(netdev);
 
+	cancel_delayed_work(&mpn->mpd->service_task);
 	netif_carrier_off(netdev);
 
 	mpnic_napi_disable(mpn);
diff --git a/drivers/net/ethernet/meta/mpnic/mpnic_pci.c b/drivers/net/ethernet/meta/mpnic/mpnic_pci.c
index 968cd611b8ea..17eae5a9ba16 100644
--- a/drivers/net/ethernet/meta/mpnic/mpnic_pci.c
+++ b/drivers/net/ethernet/meta/mpnic/mpnic_pci.c
@@ -53,6 +53,20 @@ u64 mpnic_rd64(struct mpnic_dev *mpd, u32 reg)
 	return ~0ULL;
 }
 
+static void mpnic_service_task(struct work_struct *work)
+{
+	struct mpnic_dev *mpd = container_of(to_delayed_work(work),
+					     struct mpnic_dev, service_task);
+	struct net_device *netdev = mpd->netdev;
+
+	netdev_lock(netdev);
+
+	if (netif_running(netdev))
+		schedule_delayed_work(&mpd->service_task, HZ);
+
+	netdev_unlock(netdev);
+}
+
 static struct mpnic_dev *mpnic_alloc(struct pci_dev *pdev)
 {
 	struct mpnic_dev *mpd;
@@ -69,6 +83,8 @@ static struct mpnic_dev *mpnic_alloc(struct pci_dev *pdev)
 	mpd->readrq = pcie_get_readrq(pdev);
 	mpd->relaxed_ord = pcie_relaxed_ordering_enabled(pdev);
 
+	INIT_DELAYED_WORK(&mpd->service_task, mpnic_service_task);
+
 	return mpd;
 }
 
@@ -162,6 +178,7 @@ static void mpnic_remove(struct pci_dev *pdev)
 	struct mpnic_dev *mpd = pci_get_drvdata(pdev);
 
 	unregister_netdev(mpd->netdev);
+	cancel_delayed_work_sync(&mpd->service_task);
 	mpnic_netdev_free(mpd);
 	mpnic_free_irqs(mpd);
 	kfree(mpd);

-- 
2.52.0