Re: [PATCH 2/2] drm/kms-helper: Remove struct drm_simple_display_pipe and helpers

[Thomas Zimmermann]

Hi Javier

Am 01.10.26 um 16:46 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
>
> Hello Thomas,
>
> > There are no drivers using struct drm_simple_display_pipe. Remove
> > the data type and all related helpers.
> >
> > The idea behind struct drm_simple_display_pipe was to provide an
> > easier way for writing DRM drivers besides regular atomic helpers.
> > It turned out to be more complicated. With all drivers being updated
> > to use atomic helpers, it's time to remove simple-pipe. Also clean
> > up the related TODO items.
> >
> > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > ---
> >   Documentation/gpu/todo.rst              |  17 --
> >   drivers/gpu/drm/drm_gem_atomic_helper.c |  92 -------
> >   drivers/gpu/drm/drm_simple_kms_helper.c | 328 ------------------------
> >   drivers/staging/fbtft/TODO              |   6 +-
> >   include/drm/drm_gem_atomic_helper.h     |  28 --
> >   include/drm/drm_simple_kms_helper.h     |  56 +---
> There are no more users of struct drm_simple_display_pipe but still some
> drivers include the drm_simple_kms_helper.h header. Latest drm-misc-next:
>
> git grep "drm_simple_kms_helper.h" -- drivers/gpu/drm/*/ | wc -l
> 21
>
> So it seems you need more  preparatory patches. For this patch though:

I'll take another look at it, but there's another interface in this 
header file that is (still) being used by several drivers. The header 
file still remains in place for now.

Best regards
Thomas

> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)