Re: [PATCH net-next] net: phy: qca83xx: read resolved QCA8337 link status

[Andrew Lunn]

> This covers the resolved downshift case only.

It is good testing, thanks.

> It does not show whether
> BMSR can report link up while register 0x11 is still unresolved, and
> it does not change the SPEED_UNKNOWN limitation from my previous reply.

Greed.

> Given the traffic failure, I would like to target net for v2. Three
> questions:
> 
> 1. Is net appropriate, or should this stay in net-next?

The traffic failure was however because of the error with setting the
DACs?

> 2. Is 272833b9b3b3 ("net: phy: add support for qca8k switch internal
>    PHY in at803x") the right Fixes target? It added the QCA8337 entry
>    without .read_status; I have not checked whether the problem
>    predates it. Christian, as its author, is now on Cc.

Reporting the correct downshift has nothing to do with that, as far as
i understand. Correctly reporting downshift i would put to net-next.

> 3. Compared with genphy_read_status(), the helper takes the forced-mode
>    speed from register 0x11 rather than BMCR and adds MDI-X reporting,
>    and the added genphy_read_master_slave() call runs on every poll. Is
>    that scope acceptable for net, or would you prefer a narrower fix?

net is fixing broken things, especially regressions. net-next is new
features.

	Andrew