Re: [PATCH v3 07/10] x86/virt/tdx: Convert the td_conf metadata reader

[Edgecombe, Rick P]

On Thu, 2026-10-01 at 19:34 +0300, Nikolay Borisov wrote:
> > The comments are not strictly required, but probably fit into turning this
> > thing
> > into "hand coding". I think it's a nice addition. I wonder if we should make
> > the
> > "i * 2 + j" a bit clearer though?
> > 
> > I'm not against leaving it as is for now. It helps that it doesn't morph too
> > much from the code getting moved. But I think the above falls a bit short of
> > hand coded quality.
> 
> Perhaps this code warrants open coding? The code will end up looking 
> like config_values[i][0] ... config_values[i][1] ....

Yea that would be a good way to improve it.

My only concern is how much we want to do with this series. It is already at 10
patches, and the straight move of these loops is easy to review for regressions.
That is why I was waffling on leaving it at improved comments.