Re: [PATCH v13 05/15] cxl: Introduce reusable HDM decoder settings

From: Srirangan Madhavan

Date: Thu Oct 01 2026 - 18:55:16 EST


On 9/23/26 2:39 PM, Cheatham, Benjamin wrote:
+void cxl_commit_start(void __iomem *hdm, struct cxl_decoder_settings *settings)
+{
+ lockdep_assert_held(&cxl_rwsem.dpa);
+ setup_hw_decoder(hdm, settings);
+}

- writel(ctrl, hdm + CXL_HDM_DECODER0_CTRL_OFFSET(id));
+int cxl_commit_wait(void __iomem *hdm, struct cxl_decoder_settings *settings)
No reason to rename this. Either just use cxld_await_commit() directly, or just
change the signature of cxld_await_commit().

Done in v14. I dropped cxl_commit_wait() and now call cxld_await_commit() directly.

--
Regards,
Srirangan