Re: [PATCH v6 5/5] platform/x86: bitland-mifs-wmi: Add per-machine ops table

[Mingyou Chen]

On 10/2/26 08:51, Miloš Vlku wrote:
> Follow-up to my own mail: I have now run those values rather than only
> reading them out of the tables.
>
> Built current pdx86 for-next with Chris's GET-only function-id change
> and balanced 1 / quiet 2 / performance 3 / full speed 4 on top. All four
> profiles apply and read back correctly, checked against the EC register
> each time:
>
>    low-power            -> QFAN 2
>    balanced             -> QFAN 1
>    balanced-performance -> QFAN 3
>    performance          -> QFAN 4
>
> All three power-profiles-daemon profiles work as well, so the desktop
> slider works end to end on TM2307.
>
> Two things fell out of that:
>
> - Without Chris's change every one of those writes fails with -ENOMSG
>    here, exactly as you described, and with it all of them succeed. So
>    that is a Tested-by from a second board if it is useful.
>
> - No machine-specific capability check is needed on this one.
>    WMI_FN_SYSTEM_AC_TYPE is unimplemented, Armin's work reports that as
>    -EOPNOTSUPP, and bitland_pp_check_capability() already treats that as
>    "skip the check". The stock one is fine as-is.
>
> So the TM2307 entry comes out as just a mode map plus a DMI match.
> Attached, against the v9 ops table and checkpatch-clean, in case it is
> useful to have in hand while you write the TM2309 one. I will resend it
> properly once that series settles -- posting it now mainly so the values
> sit somewhere concrete, and Mingyou can fold it straight into v10 if
> that is easier than carrying a separate patch.
>
> Thanks,
> Milos

Hi Miloš,


Just a minor note: you replied to the older v6 thread instead of 
v9, though I see you noted the dependency on v9 correctly.


The patch looks good to me.

I will include this in my patch series if v10 is necessary.


Reviewed-by: Mingyou Chen <qby140326@xxxxxxxxx>