Re: [PATCH v3 net] net/packet: guard the ll header push in packet_rcv_spkt()
From: patchwork-bot+netdevbpf
Date: Thu Oct 01 2026 - 21:40:28 EST
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:
On Mon, 28 Sep 2026 19:31:08 +0800 you wrote:
> packet_rcv_spkt() restores the link layer header with
>
> skb_push(skb, skb->data - skb_mac_header(skb));
>
> That subtraction is only meaningful when the device actually has a link
> layer header. packet_rcv() and tpacket_rcv() both wrap it in
> dev_has_header(), which is also the predicate the block comment at the
> top of the file states the restore in terms of; packet_rcv_spkt() does
> not. commit d549699048b4 ("net/packet: fix packet receive on L3
> devices without visible hard header") introduced the helper and changed
> the two call sites, and this one stayed behind.
>
> [...]
Here is the summary with links:
- [v3,net] net/packet: guard the ll header push in packet_rcv_spkt()
https://git.kernel.org/netdev/net/c/28bc1ef69961
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html