Re: [PATCH] staging: rtl8723bs: Rename CamelCase NDIS encryption state enums

[Greg Kroah-Hartman]

On Thu, Oct 01, 2026 at 02:47:10PM -0500, Marinela Tatiana Selseth wrote:
> The identifiers Ndis802_11WEPDisabled and Ndis802_11EncryptionDisabled
> violate the Linux kernel coding style guideline regarding naming
> conventions. Uppercase snake_case is preferred for enum constants.
> 
> Rename both constants to NDIS_802_11_WEP_DISABLED and
> NDIS_802_11_ENCRYPTION_DISABLED across the driver framework to conform
> to standard kernel conventions.

Why just these 2?

And shouldn't these be using the in-kernel NDIS values instead of
redefining them?  They seem to be just using random numbers, as the enum
isn't specified.  Or is this just a state value and doesn't reflect
anything actually sent to the device or network stack?

thanks,

greg k-h