Re: [PATCH bpf-next v3] selftests/bpf: add XDP test for per-flow LRU_HASH window updates

[bot+bpf-ci]

> selftests/bpf: add XDP test for per-flow LRU_HASH window updates

TL;DR: Nit only: the comment in the new xdp_lru_window.h is overlong, repeats
the commit message, and calls the shared header an "ABI"; suggests trimming it
to one line.

> diff --git a/tools/testing/selftests/bpf/xdp_lru_window.h b/tools/testing/selftests/bpf/xdp_lru_window.h
> new file mode 100644
> index 000000000000..78434045cf11
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/xdp_lru_window.h
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __XDP_LRU_WINDOW_H
> +#define __XDP_LRU_WINDOW_H
> +
> +/*
> + * ABI for the XDP LRU rolling-window selftest. Existing test_lru_map
> + * coverage never enters XDP; XDP parse tests do not store a modulo
> + * index into an LRU map value.
> + */
> +
> +#define AGGREGATION_WINDOW	50
> +#define XDP_LRU_WINDOW_FLOWS	64

This isn't a bug, but could this header comment be trimmed down?

Most of it restates the first paragraph of the commit message and describes
what other selftests do and do not cover, rather than what this header
defines.  A statement like "Existing test_lru_map coverage never enters XDP"
can go stale when another test adds similar coverage.

It also calls a struct shared between one BPF object and one test_progs file
an "ABI".  The neighbouring shared headers (test_tcpbpf.h, test_tcpnotify.h,
xdp_metadata.h) do not carry a comment like this.

Could the coverage reasoning stay in the commit message only, leaving at most
a one-line note about what is shared between the BPF program and the test
runner?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/36971050072