Re: [PATCH v5 1/8] serial: max310x: don't clobber the TX break bit in set_termios

[Tapio Reijonen]

Hi Hugo,

On Tue, 29 Sep 2026 09:40:19 -0400, Hugo Villeneuve wrote:
> > max310x_set_termios() writes the LCR register absolutely, but LCR
> > also
>
> What do you mean by "absolutely"? I think you should rephrase that...

Agreed, that reads wrong. v6 says "unconditionally"/"unconditional"
instead, in the commit message and in both code comments (the short
one added here and the expanded one in the software-RTS patch).

Tapio