Re: [PATCH RFC v4 02/13] efi: bgrt: export the BGRT table and image size
From: Ard Biesheuvel
Date: Fri Oct 02 2026 - 03:49:10 EST
On Thu, 1 Oct 2026, at 21:58, Màxim Pedraza Padilla wrote:
> The DRM splash client reads the boot graphics the firmware left behind
> through bgrt_tab and bgrt_image_size. Built as part of drm_client_lib,
> which can be a module, it then fails to link:
>
> ERROR: modpost: drivers/gpu/drm/clients/drm_client_lib.ko: symbol
> 'bgrt_tab' undefined!
> ERROR: modpost: drivers/gpu/drm/clients/drm_client_lib.ko: symbol
> 'bgrt_image_size' undefined!
>
> Export both. They are filled in once, early in boot, and only read
> after that.
>
Mind making these __ro_after_init while at it? Conceptually, they
already are and should be annotated as such for robustness. This
becomes more important once we expose them to modules.
Acked-by: Ard Biesheuvel <ardb@xxxxxxxxxx>